Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mediaviewer): Refresh token if token expired #1087

Merged
merged 6 commits into from
Oct 29, 2019

Conversation

mxiao6
Copy link
Contributor

@mxiao6 mxiao6 commented Oct 23, 2019

Will add tests later. The related BUIE change: box/box-ui-elements#1689

@mxiao6 mxiao6 requested a review from a team as a code owner October 23, 2019 22:51
@boxcla
Copy link

boxcla commented Oct 23, 2019

Verified that @mxiao6 has signed the CLA. Thanks for the pull request!

Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it should be a feat or fix instead of chore?

src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
@mxiao6 mxiao6 changed the title chore(mediaviewer): refresh token if token expired fix(mediaviewer): Refresh token if token expired Oct 24, 2019
@mxiao6 mxiao6 force-pushed the refresh-token branch 2 times, most recently from fa8b298 to a78bade Compare October 24, 2019 21:46
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/Preview.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
@mxiao6 mxiao6 force-pushed the refresh-token branch 2 times, most recently from 547da31 to 9d4fcda Compare October 28, 2019 20:27
ConradJChan
ConradJChan previously approved these changes Oct 28, 2019
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Show resolved Hide resolved
src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/Preview.js Show resolved Hide resolved
src/lib/Preview.js Show resolved Hide resolved
Copy link
Contributor

@ConradJChan ConradJChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did we land on the UX of when the token expires during playback?

src/lib/viewers/media/DashViewer.js Outdated Show resolved Hide resolved
src/lib/viewers/media/MediaBaseViewer.js Outdated Show resolved Hide resolved
@mxiao6
Copy link
Contributor Author

mxiao6 commented Oct 29, 2019

Where did we land on the UX of when the token expires during playback?

The video/audio will stuck just like before.

@mergify mergify bot merged commit a69c0aa into box:master Oct 29, 2019
@mxiao6 mxiao6 deleted the refresh-token branch December 13, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants